<html>
<head><meta charset="utf-8"><title>rustfmt · t-compiler/wg-mir-opt · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/index.html">t-compiler/wg-mir-opt</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html">rustfmt</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="164551817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551817">(Apr 30 2019 at 16:13)</a>:</h4>
<p>also, I saw you pointed to a weird indent thing</p>



<a name="164551830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551830">(Apr 30 2019 at 16:13)</a>:</h4>
<p>I wonder how most of the people deal with this kind of stuff</p>



<a name="164551836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551836">(Apr 30 2019 at 16:13)</a>:</h4>
<p>that was specifically the indentation offered by vim</p>



<a name="164551841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551841">(Apr 30 2019 at 16:13)</a>:</h4>
<p>most of the time I just use rustfmt</p>



<a name="164551846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551846">(Apr 30 2019 at 16:13)</a>:</h4>
<p>but of course I don't want to do that during this PR</p>



<a name="164551847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551847">(Apr 30 2019 at 16:13)</a>:</h4>
<p>:)</p>



<a name="164551852"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551852" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551852">(Apr 30 2019 at 16:13)</a>:</h4>
<p>it would become unmergeable forever</p>



<a name="164551865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551865">(Apr 30 2019 at 16:13)</a>:</h4>
<p>unless the files I deal with are already rustfmted</p>



<a name="164551952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551952">(Apr 30 2019 at 16:14)</a>:</h4>
<p>I'd really really love to see a rustfmt --over-git-diffs</p>



<a name="164551958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551958">(Apr 30 2019 at 16:14)</a>:</h4>
<p>yea... It's super uncool, but I guess we're working on it</p>



<a name="164551970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164551970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164551970">(Apr 30 2019 at 16:15)</a>:</h4>
<p>rustfix and clippy via <code>x.py</code> are already becoming a thing</p>



<a name="164552009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164552009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164552009">(Apr 30 2019 at 16:15)</a>:</h4>
<p>Maybe we can make tidy have a blacklist of not-rustfmted things and slowly remove things from that blacklist</p>



<a name="164552415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164552415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164552415">(Apr 30 2019 at 16:20)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span>  I think that's the basic idea petrochenkov had to prove it out</p>



<a name="164552423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164552423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164552423">(Apr 30 2019 at 16:20)</a>:</h4>
<p>much like the edition migration</p>



<a name="164554295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164554295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164554295">(Apr 30 2019 at 16:45)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="164554299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164554299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164554299">(Apr 30 2019 at 16:45)</a>:</h4>
<p>sounds good</p>



<a name="164554319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164554319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164554319">(Apr 30 2019 at 16:46)</a>:</h4>
<p>anyway seems like rustfmt over the diffs would be great :)</p>



<a name="164554529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164554529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164554529">(Apr 30 2019 at 16:48)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span>  someone just needs to implement everything and we are golden :D</p>



<a name="164554548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164554548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164554548">(Apr 30 2019 at 16:48)</a>:</h4>
<p>maybe we should just make E-easy issues and someone will magically pick it up</p>



<a name="164555165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164555165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164555165">(Apr 30 2019 at 16:57)</a>:</h4>
<p>yes :)</p>



<a name="164555216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164555216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164555216">(Apr 30 2019 at 16:57)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> ^--- maybe you can write something up since you had ideas?</p>



<a name="164556179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164556179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164556179">(Apr 30 2019 at 17:09)</a>:</h4>
<p>if sounds interesting I can just open an issue on rustfmt</p>



<a name="164556242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164556242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164556242">(Apr 30 2019 at 17:10)</a>:</h4>
<p>but more than an issue is the ability to add a feature</p>



<a name="164556286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164556286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164556286">(Apr 30 2019 at 17:10)</a>:</h4>
<p>to run rustfmt over a list of range of lines of code</p>



<a name="164556305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164556305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164556305">(Apr 30 2019 at 17:11)</a>:</h4>
<p>like from line 1 to 10, then from 20 to 40 and so on</p>



<a name="164556329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164556329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164556329">(Apr 30 2019 at 17:11)</a>:</h4>
<p>and on top of that build adapters for different scms</p>



<a name="164559593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164559593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164559593">(Apr 30 2019 at 17:51)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span>  we also need <code>x.py</code> support and tidy checks</p>



<a name="164559606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164559606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164559606">(Apr 30 2019 at 17:51)</a>:</h4>
<p>and eventually possibly some <code>@bors fmt</code> command</p>



<a name="164561904"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164561904" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164561904">(Apr 30 2019 at 18:16)</a>:</h4>
<p>I don't have any firm ideas, I personally think that rustfmt in theory shouldn't really need deep integration into rustbuild since dependencies shouldn't need to be built</p>



<a name="164562597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164562597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164562597">(Apr 30 2019 at 18:23)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I was thinking more like mentoring instructions :P</p>



<a name="164562736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164562736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164562736">(Apr 30 2019 at 18:24)</a>:</h4>
<p>I'm not quite sure for what though</p>



<a name="164562796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164562796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164562796">(Apr 30 2019 at 18:24)</a>:</h4>
<p>if it's x.py fmt then I imagine it wouldn't be too hard to do so, but I also don't think it's super necessary.</p>



<a name="164563039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164563039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164563039">(Apr 30 2019 at 18:27)</a>:</h4>
<p>I think there are two different things one is the integration with the compiler and the other one is having rustfmt be able to use git diffs to only affect the changed lines and not the entire file</p>



<a name="164563048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164563048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164563048">(Apr 30 2019 at 18:27)</a>:</h4>
<p>I was mainly talking about the second thing</p>



<a name="164563084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164563084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164563084">(Apr 30 2019 at 18:27)</a>:</h4>
<p>the integration with the compiler is a thing that I know was being discussed but seems to me something more like mid/long term</p>



<a name="164563178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164563178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164563178">(Apr 30 2019 at 18:28)</a>:</h4>
<p>if you're able to run rustfmt over diffs could be something one could apply in all the PRs</p>



<a name="164605756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164605756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164605756">(May 01 2019 at 07:16)</a>:</h4>
<p>ah, now I remember the relevant discussion: What we want is not for CI to complain to you when you forget, but for CI to automatically rustfmt and add a commit. Otherwise it's a lot of noise for contributors</p>



<a name="164605973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164605973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164605973">(May 01 2019 at 07:23)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> I thought we wanted CI to reject your PR on poor formatting</p>



<a name="164606020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164606020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164606020">(May 01 2019 at 07:24)</a>:</h4>
<p>and then to add a tool <code>@bors fmt</code> so you can add a commit that fixes it</p>



<a name="164606038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164606038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164606038">(May 01 2019 at 07:25)</a>:</h4>
<p>Maybe I should write an RFC?</p>



<a name="164607960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164607960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164607960">(May 01 2019 at 08:12)</a>:</h4>
<p>I didn't think there was consensus on having a bot add a commit automatically vs tidy failing and a subcommand to format/bot to request a commit.</p>



<a name="164608373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt/near/164608373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/189540-t-compiler/wg-mir-opt/topic/rustfmt.html#164608373">(May 01 2019 at 08:20)</a>:</h4>
<p>Seems unclear what the consensus is then... best to find out the hard way</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>